Skip to content

Fix: prevent key prop warning in EthHashInfo #5013

Fix: prevent key prop warning in EthHashInfo

Fix: prevent key prop warning in EthHashInfo #5013

Triggered via pull request August 4, 2023 18:32
@katspaughkatspaugh
opened #2351
Status Success
Total duration 16s
Artifacts

cla.yml

on: pull_request_target
CLAAssistant
5s
CLAAssistant
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 1 warning
ApprovalEditorForm > should render and edit multiple txs: src/components/tx/ApprovalEditor/ApprovalEditorForm.test.tsx#L14
Error: expect(received).toHaveLength(expected) Expected length: 2 Received length: 4 Received array: [<button class="MuiButtonBase-root Mui-disabled MuiIconButton-root Mui-disabled MuiIconButton-sizeMedium iconButton css-whz9ym-MuiButtonBase-root-MuiIconButton-root" disabled="" tabindex="-1" title="Save" type="button"><svg aria-hidden="true" class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1lnqmb1-MuiSvgIcon-root-MuiSvgIcon-root" data-testid="CheckIcon" focusable="false" viewBox="0 0 24 24"><path d="M9 16.17 4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z" /></svg></button>, <button aria-label="" class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-1o2vr87-MuiButtonBase-root-MuiIconButton-root" data-mui-internal-clone-element="true" href="" rel="noreferrer" tabindex="0" target="_blank" type="button"><mock-icon aria-hidden="true" classname="MuiSvgIcon-root MuiSvgIcon-fontSizeSmall css-11dtfly-MuiSvgIcon-root" focusable="false" /><span class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root" /></button>, <button class="MuiButtonBase-root Mui-disabled MuiIconButton-root Mui-disabled MuiIconButton-sizeMedium iconButton css-whz9ym-MuiButtonBase-root-MuiIconButton-root" disabled="" tabindex="-1" title="Save" type="button"><svg aria-hidden="true" class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1lnqmb1-MuiSvgIcon-root-MuiSvgIcon-root" data-testid="CheckIcon" focusable="false" viewBox="0 0 24 24"><path d="M9 16.17 4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z" /></svg></button>, <button aria-label="" class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-1o2vr87-MuiButtonBase-root-MuiIconButton-root" data-mui-internal-clone-element="true" href="" rel="noreferrer" tabindex="0" target="_blank" type="button"><mock-icon aria-hidden="true" classname="MuiSvgIcon-root MuiSvgIcon-fontSizeSmall css-11dtfly-MuiSvgIcon-root" focusable="false" /><span class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root" /></button>] at Object.toHaveLength (/home/runner/work/safe-wallet-web/safe-wallet-web/src/components/tx/ApprovalEditor/ApprovalEditorForm.test.tsx:43:21) at Promise.then.completed (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/utils.js:333:28) at new Promise (<anonymous>) at callAsyncCircusFn (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/utils.js:259:10) at _callCircusTest (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/run.js:277:40) at _runTest (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/run.js:209:3) at _runTestsForDescribeBlock (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/run.js:97:9) at _runTestsForDescribeBlock (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/run.js:91:9) at run (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/run.js:31:3) at runAndTransformResultsToJestFormat (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:135:21) at jestAdapter (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:92:19) at runTestInternal (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-runner/build/runTest.js:411:16) at runTest (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/jest-runner/build/runTest.js:499:34)
ApprovalEditorForm > should render and edit single tx: src/components/tx/ApprovalEditor/ApprovalEditorForm.test.tsx#L76
TestingLibraryElementError: Found multiple elements with the role "button" Here are the matching elements: Ignored nodes: comments, script, style <button class="MuiButtonBase-root Mui-disabled MuiIconButton-root Mui-disabled MuiIconButton-sizeMedium iconButton css-whz9ym-MuiButtonBase-root-MuiIconButton-root" disabled="" tabindex="-1" title="Save" type="button" > <svg aria-hidden="true" class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1lnqmb1-MuiSvgIcon-root-MuiSvgIcon-root" data-testid="CheckIcon" focusable="false" viewBox="0 0 24 24" > <path d="M9 16.17 4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z" /> </svg> </button> Ignored nodes: comments, script, style <button aria-label="" class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-1o2vr87-MuiButtonBase-root-MuiIconButton-root" data-mui-internal-clone-element="true" href="" rel="noreferrer" tabindex="0" target="_blank" type="button" > <mock-icon aria-hidden="true" classname="MuiSvgIcon-root MuiSvgIcon-fontSizeSmall css-11dtfly-MuiSvgIcon-root" focusable="false" /> <span class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root" /> </button> (If this is intentional, then use the `*AllBy*` variant of the query (like `queryAllByText`, `getAllByText`, or `findAllByText`)). Ignored nodes: comments, script, style <body> <div> <ul class="MuiList-root MuiList-padding approvalsList css-h4y409-MuiList-root" > <li class="MuiListItem-root MuiListItem-gutters css-1xt1ued-MuiListItem-root" data-testid="approval-item" > <div class="MuiPaper-root MuiPaper-elevation MuiPaper-rounded MuiPaper-elevation0 MuiAlert-root MuiAlert-outlinedWarning MuiAlert-outlined alert css-eguulm-MuiPaper-root-MuiAlert-root" role="alert" > <div class="MuiAlert-message css-1pxa9xg-MuiAlert-message" > <div class="MuiGrid-root MuiGrid-container css-1d0yk0s-MuiGrid-root" > <div class="MuiGrid-root MuiGrid-item MuiGrid-grid-xs-12 css-bll3ux-MuiGrid-root" > <div class="MuiAutocomplete-root MuiAutocomplete-fullWidth css-1kkal6p-MuiAutocomplete-root" > <div class="MuiFormControl-root MuiFormControl-fullWidth MuiTextField-root css-wb57ya-MuiFormControl-root-MuiTextField-root" > <label class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-shrink MuiInputLabel-sizeSmall MuiInputLabel-outlined MuiFormLabel-colorPrimary MuiFormLabel-filled MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-shrink MuiInputLabel-sizeSmall MuiInputLabel-outlined css-18pzvfc-MuiFormLabel-root-MuiInputLabel-root" data-shrink="true" for=":r6:" id=":r6:-label" > Token </label> <div class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl MuiInputBase-sizeSmall MuiInputBase-adornedStart MuiAutocomplete-inputRoot css-1da4kce-MuiInputBase-root-MuiOutlinedInput-root" > <div class="MuiBox-root css-ct9q29" > <img alt="TST" class="image" height="32" src="/images/common/token-placeholder.svg" /> <p class="MuiTypography-root MuiTypography-body1 css-1pqjor9-MuiTypography-root" > TST </p> </div> <input aria-autocomplete="list" aria-expanded="false" aria-invalid="false" autocapitalize="none" autocomplete="off" class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputSizeSmall MuiInputBase-inputAdornedStart approvalAmount css-1n5qv81-MuiInputBase-input-MuiOutlinedInput-input" id=":r6:" name="approvals.0" role="combobox" spellcheck="false" type="text" value="420.0" /> <fieldset aria-hidden="true" class="MuiOutlinedInput-notchedOutline css-p7vjcx-MuiOutlinedInput-notchedOutline" > <legend class="css-14lo706" > <span> Token </span> </legend> </fieldset> </div> </div> </div> <span data-track="modals: Edit approval" > <button class="MuiButtonBase-root Mui-disabled MuiIconButton-root Mui-disabled MuiIconButton-sizeMedium iconButton css-whz9ym-MuiButtonBase-root-MuiIconButton-root" disabled="" tabindex="-1" title="Save" type="button" > <svg aria-hidden="true" class="MuiSvgIcon-root MuiSvgIcon-fontSizeMedium MuiSvgIcon-root MuiSvgIcon-fontSizeMedium css-1lnqmb1-MuiSvgIcon-root-MuiSvgIcon-root" data-testid="CheckIcon" focusable="false" viewBox="0 0 24 24" > <path d="M9 16.17 4.83 12l-1.42 1.41L9 19 21 7l-1.41-1.41z" /> </svg> </button> </span> </div> <div class="MuiGrid-root MuiGrid-container MuiGrid-item MuiGrid-grid-xs-12 css-1bg6mhv-MuiGrid-root" > <div class="MuiGrid-root MuiGrid-item MuiGrid-grid-xs-2 css-1o7apob-MuiGrid-root" > <p class="MuiTypography-root MuiTypography-body2 css-13ba1nr-MuiTypography-root" > Spender </p> </div> <div class="MuiGrid-root MuiGrid-item css-13i4rnv-MuiGrid-root" > <p class="MuiTypography-root MuiTypography-body1 css-1021waj-MuiTypography-root" > <div class="container" > <div class="css-g4th7g" > <div class="MuiBox-root css-i6bazn" > <div class="css-8np9li" > <div class="MuiBox-root css-1or163" > <span> 0x2 </span> </div> <div class="MuiBox-root css-yjghm1" > <button aria-label="" class="MuiButtonBase-root MuiIconButton-root MuiIconButton-sizeSmall css-1o2vr87-MuiButtonBase-root-MuiIconButton-root" data-mui-internal-clone-element="true" href="" rel="noreferrer" tabindex="0" target="_blank" type="button" > <mock-icon aria-hidden="true" classname="MuiSvgIcon-root MuiSvgIcon-fontSizeSmall css-11dtfly-MuiSvgIcon-root" focusable="false" /> <span class="MuiTouchRipple-root css-8je8zh-MuiTouchRipple-root" /> </button> </div> </div> </div> </div> </div> </p> </div> </div> </div> </div> </div> </li> </ul> </div> </body> at Object.getElementError (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/@testing-library/dom/dist/config.js:40:19) at getElementError (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/@testing-library/dom/dist/query-helpers.js:25:35) at getMultipleElementsFoundError (/home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/@testing-library/dom/dist/query-helpers.js:29:10) at /home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/@testing-library/dom/dist/query-helpers.js:66:13 at /home/runner/work/safe-wallet-web/safe-wallet-web/node_modules/@testing-library/dom/dist/query-helpers.js:111:19 at Object.getByRole (/home/runner/work/safe-wallet-web/safe-wallet-web/src/components/tx/ApprovalEditor/ApprovalEditorForm.test.tsx:103:31)
CLAAssistant
The following actions uses node12 which is deprecated and will be forced to run on node16: contributor-assistant/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/