Install jq 1.7 to handle large gwei balance #588
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #586 .
Many factory deployment actions fail because too many ethers are sent to the bot's account. For example, I sent 10^19 gwei in https://github.com/safe-global/safe-singleton-factory/actions/runs/10001624545/job/27645578947 , and the bash script thinks I have -8446744073709551616 gwei, where 10^19 + 8446744073709551616 == 2^64. The reason may be...
safe-singleton-factory/.github/scripts/validate_new_chain_request.sh
Line 183 in 4da1be4
The bash tool jq cannot handle numbers larger than 2^63 correctly.
jqlang/jq#1959 (comment)
jq 1.7 fixed the problem
actions/runner-images#9550 (comment)
But github actions is not willing to upgrade jq to 1.7 .
I have not tested this pull request.