Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Passkey Verification #486

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Fix Passkey Verification #486

merged 1 commit into from
Aug 20, 2024

Commits on Aug 19, 2024

  1. Fix Passkey Verification

    In deploying the contracts, I noticed that the local verification script
    wasn't working as well as Etherscan verification of the FCL verifier
    contract. This PR fixes both of these things and is related to a couple
    issues:
    
    1. The `solc` package version was not correctly specified for each
       `localVerify` script. It was pulling in a `solc` version based on
       transient dependencies which doesn't necessarily match what the
       contracts are compiled with (and thus affects local verification).
       This was an issue shared by all Solidity packages.
    2. Local verification was not correctly building the Solidity compiler
       input JSON. It turns out that the way we build compiler input would
       sometimes only pass in the Keccak-256 hash of the source instead of
       the actual Solidity source - so we add an additional condition in the
       task to read the source from disk if necessary.
    3. The `etherscan-verify` task from the `hardhat-deploy` package does
       not work for contracts with Solidity compiler settings overrides such
       as the FCL P-256 verifier contract (which has different compiler
       settings from the rest of the contracts). We have a special manual
       `hardhat-verify` plugin call in the `deploy-all` task to work around
       the issue.
    nlordell committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    9ba9186 View commit details
    Browse the repository at this point in the history