Fix Flaky WebAuthn Shim Test #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
nlordell
commented
Jul 23, 2024
| @@ -54,7 +54,6 @@ | |||
| "@openzeppelin/contracts": "^5.0.2", | |||
| "@safe-global/safe-4337-local-bundler": "workspace:^0.0.0", | |||
| "@safe-global/safe-4337-provider": "workspace:^0.0.0", | |||
| "@simplewebauthn/server": "^10.0.0", | |||
There was a problem hiding this comment.
unused dependency.
remedcu
approved these changes
Jul 23, 2024
Pull Request Test Coverage Report for Build 10058774386Details
💛 - Coveralls |
nlordell
force-pushed
the
chore/fix-flaky-webauthn-test
branch
2 times, most recently
from
63c7478
to
2b36085
Compare
Fixes #369 This PR bumps the version of `@simplewebauthn/server` to include a fix to which was causing flacky tests for our WebAuthn shim. It turns out that the library was not correctly dealing with leading zeros in the signature `r` or `s` value, which would cause the test to periodically fail (since the signature was random in each run - as both the private kay and the challenge were randomly generated).
nlordell
force-pushed
the
chore/fix-flaky-webauthn-test
branch
from
2b36085
to
7349fb8
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369
This PR bumps the version of
@simplewebauthn/serverto include a fix to which was causing flacky tests for our WebAuthn shim. It turns out that the library was not correctly dealing with leading zeros in the signaturerorsvalues, which would cause the test to periodically fail (since the signature was random in each run - as both the private key and the challenge were randomly generated, meaning that we would occasionally have anrorsvalue with a leading0byte).