Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gelato using execTransaction for gas metering #326

Merged
merged 17 commits into from
Mar 19, 2024
Merged

Gelato using execTransaction for gas metering #326

merged 17 commits into from
Mar 19, 2024

Conversation

remedcu
Copy link
Member

@remedcu remedcu commented Mar 14, 2024

This PR converts the gas metering check from using 4337 EntryPoint v0.6 to using execTransaction directly in Safe.

Package Lock has been updated due to the addition of the Gelato relay kit package.

Changes:

  • Allow execution of Gelato-based transactions in base-sepolia as well.
  • Updating gas metering in README's from Gelato based on execTransaction.
  • Introduction of abi, address and types files into its location.
  • Changing from userOp of 4337 to execTransaction of Safe for Gelato-based transactions.
  • Installation of Gelato Relay Kit. (Earlier RPC calls were used directly for userOps).
  • Additional functions for Gelato-based operations in safe.ts (Creating calldata, init code, etc.).
  • Removal of userOp related functions of Gelato.

Closes #296

@remedcu remedcu self-assigned this Mar 14, 2024
@remedcu remedcu requested a review from a team as a code owner March 14, 2024 15:57
@remedcu remedcu requested review from nlordell, akshay-ap and mmv08 and removed request for a team March 14, 2024 15:57
@coveralls
Copy link

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 8328578423

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+62.4%) to 76.923%

Totals Coverage Status
Change from base Build 8328447414: 62.4%
Covered Lines: 131
Relevant Lines: 155

💛 - Coveralls

Copy link
Collaborator

@nlordell nlordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

There are some linter warnings that would be nice to clean up, but that can be done in a follow up.

@remedcu remedcu merged commit 1675523 into main Mar 19, 2024
14 checks passed
@remedcu remedcu deleted the gelato-4337 branch March 19, 2024 08:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Gelato Gas Metering Example to Use execTransaction
4 participants