Skip to content

Commit

Permalink
Update modules/4337/contracts/Safe4337Module.sol
Browse files Browse the repository at this point in the history
Co-authored-by: Nicholas Rodrigues Lordello <[email protected]>
  • Loading branch information
akshay-ap and nlordell authored Aug 8, 2024
1 parent bad4fa6 commit f7f1214
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion modules/4337/contracts/Safe4337Module.sol
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ contract Safe4337Module is IAccount, HandlerContext, CompatibilityFallbackHandle
* fixed in size, the Smart Contract signature can be of arbitrary length. Safe encodes the Smart Contract
* signature length in the signature data. If appropriate length checks are not performed during the signature
* verification then a malicious bundler can pad additional bytes to the signatures data and make the account pay
* more gas than needed for user operation validation and reach the verificationGasLimit.
* more gas than needed for user operation validation and reach the `verificationGasLimit`.
* `_checkSignaturesLength` function checks for the presence of any padded bytes to the `signature` data.
* However, there is an edge case that `_checkSignaturesLength` function cannot detect.
* Since the `signature` field in UserOp is not part of the UserOp hash a malicious bundler can manipulate the
Expand Down

0 comments on commit f7f1214

Please sign in to comment.