Skip to content

Commit

Permalink
Safe 4337 Module v0.3.0 (#331)
Browse files Browse the repository at this point in the history
This PR does the final touches for the Safe 4337 module v0.3.0. Namely,
it:

- uploads the audit report
- updates the final address the module is expected to land on
  • Loading branch information
nlordell authored Mar 19, 2024
1 parent 1675523 commit 5931a27
Show file tree
Hide file tree
Showing 6 changed files with 17 additions and 1 deletion.
2 changes: 1 addition & 1 deletion modules/4337/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ The official deployments support the EntryPoint v0.7.0 with the canonical deploy
## Expected addresses

- `SafeModuleSetup` at `0x2dd68b007B46fBe91B9A7c3EDa5A7a1063cB5b47`
- `Safe4337Module` at `0xfaa6F2eC82BdA7C22220522869E854a3446053A5`
- `Safe4337Module` at `0x75cf11467937ce3F2f357CE24ffc3DBF8fD5c226`

## Changes

Expand Down
1 change: 1 addition & 0 deletions modules/4337/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ npx hardhat --network <network> etherscan-verify

- [For version 0.1.0 by Ackee Blockchain](docs/v0.1.0/audit.md)
- [For version 0.2.0 by Multiple Auditors](docs/v0.2.0/audit.md)
- [For version 0.3.0 by Ackee Blockchain](docs/v0.3.0/audit.md)

## Security and Liability

Expand Down
2 changes: 2 additions & 0 deletions modules/4337/docs/v0.2.0/audit.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@ The final audit was performed on commit [3853f34f31837e0a0aee47a4452564278f8c62b

No issues were reported related to the module's business logic, but we have implemented some of the suggested optimisations from the audit report into the codebase. These changes will be included in the next release of the 4337 module. For more information about the audit findings, please refer to the report.

Changes from the audit were implemented in commit [c2bdf0059770916ad178a45c2ad6f2cb88f85ff7](https://github.com/safe-global/safe-modules/tree/c2bdf0059770916ad178a45c2ad6f2cb88f85ff7).

### Files

- [Final audit report](audit-report-openzeppelin.pdf)
Binary file added modules/4337/docs/v0.3.0/audit-report-v3.0.pdf
Binary file not shown.
13 changes: 13 additions & 0 deletions modules/4337/docs/v0.3.0/audit.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Audit Results

## Auditor

Ackee Blockchain (<https://ackeeblockchain.com/>).

## Notes

The final audit was performed on commit [7b3ea24cf06dca2bc88405fd1c991b2338f565f8](https://github.com/safe-global/safe-modules/tree/7b3ea24cf06dca2bc88405fd1c991b2338f565f8).

### Files

- [Final audit report](audit-report-v3.0.pdf)

0 comments on commit 5931a27

Please sign in to comment.