Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated classes #835

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Remove deprecated classes #835

merged 5 commits into from
Jul 12, 2024

Conversation

Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Mar 15, 2024 •
edited
Loading

@Uxio0 Uxio0 requested a review from a team as a code owner March 15, 2024 10:59
@Uxio0 Uxio0 self-assigned this Mar 15, 2024
@Uxio0 Uxio0 added the breaking_change Breaking change label Mar 15, 2024
@Uxio0 Uxio0 changed the title remove deprecated classes Remove deprecated classes Mar 15, 2024
falvaradorodriguez
falvaradorodriguez reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, It's necessary to do this safe-global/safe-transaction-service#1951

@Uxio0 Uxio0 force-pushed the remove-deprecated-classes branch from 6115926 to 7131e4d Compare July 10, 2024 09:25
@coveralls
Copy link

coveralls commented Jul 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9907968941

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 4 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.05%) to 93.623%
Files with Coverage Reduction New Missed Lines %
gnosis/eth/ethereum_client.py 1 86.12%
gnosis/safe/tests/utils.py 1 60.0%
gnosis/eth/clients/ens_client.py 1 59.38%
gnosis/safe/safe_tx.py 1 90.97%
Totals Coverage Status
Change from base Build 9871609960: 0.05%
Covered Lines: 8133
Relevant Lines: 8687
💛 - Coveralls

Uxio0 added a commit that referenced this pull request Jul 12, 2024
@Uxio0
Create EthereumAddressFastBinaryField
3793e96 
- Faster than `EthereumAddressBinaryField` as it does not involve
EIP55 checksums
- Depends on #835 to be merged first
@Uxio0 Uxio0 mentioned this pull request Jul 12, 2024
Merged
Uxio0 added a commit that referenced this pull request Jul 12, 2024
@Uxio0
Create EthereumAddressFastBinaryField
0190c35 
- Faster than `EthereumAddressBinaryField` as it does not involve
EIP55 checksums
- Depends on #835 to be merged first
Uxio0 added a commit that referenced this pull request Jul 12, 2024
@Uxio0
Create EthereumAddressFastBinaryField
80e1441 
- Faster than `EthereumAddressBinaryField` as it does not involve
EIP55 checksums
- Depends on #835 to be merged first
@Uxio0 Uxio0 merged commit c917c59 into main Jul 12, 2024
7 checks passed
@Uxio0 Uxio0 deleted the remove-deprecated-classes branch July 12, 2024 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@falvaradorodriguez falvaradorodriguez falvaradorodriguez approved these changes

@calmbeforeu calmbeforeu calmbeforeu approved these changes

Assignees

@Uxio0 Uxio0

Labels
breaking_change Breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate not used Safe Serializers
4 participants
@Uxio0 @coveralls @falvaradorodriguez @calmbeforeu