Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Haqq networks #730

Merged
merged 12 commits into from
Jan 24, 2024
Merged

Conversation

Hirama
Copy link
Contributor

@Hirama Hirama commented Jan 9, 2024

Please add Haqq Mainnet and HaqqTestnet:

safe-global/safe-deployments#335

Thank you!

@Hirama Hirama requested a review from a team as a code owner January 9, 2024 12:24
@Hirama Hirama requested review from fmrsabino, moisses89 and iamacook and removed request for a team January 9, 2024 12:24
Copy link
Contributor

github-actions bot commented Jan 9, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Hirama
Copy link
Contributor Author

Hirama commented Jan 9, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 9, 2024
Copy link
Member

@moisses89 moisses89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, could you check the addresses?

gnosis/eth/ethereum_network.py Outdated Show resolved Hide resolved
gnosis/safe/addresses.py Outdated Show resolved Hide resolved
@Hirama
Copy link
Contributor Author

Hirama commented Jan 16, 2024

@moisses89 thanks for comments! I have applied fixes.

@Hirama Hirama requested a review from moisses89 January 16, 2024 18:23
@moisses89
Copy link
Member

@Hirama could you fix the conflicts, ping me when ready.

@Hirama
Copy link
Contributor Author

Hirama commented Jan 23, 2024

@moisses89 resolved, please check

@moisses89 moisses89 merged commit 0a1358a into safe-global:master Jan 24, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants