Support Safe Singleton Factory #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uxio0
force-pushed
the
deploy-test-contracts-singleton
branch
from
89367ab
to
a3e681e
Compare
Uxio0
force-pushed
the
deploy-test-contracts-singleton
branch
from
a3e681e
to
9eb7caa
Compare
Uxio0
force-pushed
the
deploy-test-contracts-singleton
branch
2 times, most recently
from
40f05fb
to
c4de996
Compare
- Add deterministic contract deployment Optimizes testing: - Speed up tests, as it's easy to check if contracts are deployed - Less confusing, as contract addresses will be the same to production environments
Uxio0
force-pushed
the
deploy-test-contracts-singleton
branch
from
c4de996
to
f76b2e3
Compare
falvaradorodriguez
approved these changes
Mar 12, 2024
moisses89
reviewed
Mar 12, 2024
| @@ -45,7 +45,8 @@ def setUpClass(cls): | |||
| cls.multicall = cls.ethereum_client.multicall | |||
| assert cls.multicall, "Multicall must be defined" | |||
|
|
|||
| def get_ethereum_test_account(self) -> LocalAccount: | |||
| @classmethod | |||
| def get_ethereum_test_account(cls): | |||
There was a problem hiding this comment.
Suggested change
| def get_ethereum_test_account(cls): | |
| def get_ethereum_test_account(cls) -> LocalAccount: |
I'm not sure if should be a classmethod because is not using anything from class.
There was a problem hiding this comment.
It's used from another classmethod, so it has to be a classmethod
moisses89
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes testing: