Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api-kit): remove /api autocomplete and add missing chains #994

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

dasanra
Copy link
Collaborator

@dasanra dasanra commented Oct 2, 2024

What it solves

Resolves #978

How this PR fixes it

Removes the /api addition for default transaction service urls. Some devs where looking the config.ts file when trying to initialize theirs and didn't notice they should be providing the full URL.

Also adds missing supported chains

  • XLayer
  • Mantle
  • Blast
  • Scroll

@dasanra dasanra requested a review from yagopv October 2, 2024 14:06
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11145388971

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.73%

Totals Coverage Status
Change from base Build 11142074385: 0.0%
Covered Lines: 777
Relevant Lines: 948

💛 - Coveralls

@dasanra dasanra linked an issue Oct 3, 2024 that may be closed by this pull request
@dasanra dasanra merged commit 359b925 into development Oct 3, 2024
20 checks passed
@dasanra dasanra deleted the align-api-kit-config branch October 3, 2024 10:56
@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Api kit initialisation issue
3 participants