feat(protocol-kit): Add deployment functionality to Safe class #980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `SafeWebAuthnSignerFactory` contract * Add tests for passkey flow in `isOwner` function * Add tests for signTransaction + createAddOwnerTx (wip) * Add webauthnShim to emulate the Web Authentication API implemented in browsers Copied from [safe-modules repo](https://github.com/safe-global/safe-modules/blob/main/modules/passkey/test/utils/webauthnShim.ts) * Use webauthnShim for passkey mocks * Deploy `FCLP256Verifier` in local hardhat environment and use it as as WebAuthnContract * Run passkey tests only for contract versions 1.3.0 + 1.4.1 --------- Co-authored-by: Daniel Somoza <[email protected]>
…f a hardcoded address
Passkey 4337 support
…#855) * Add test on the provider level
dasanra
changed the base branch from
added-deployment-safe-class-viem
to
development
dasanra
changed the title
Pull Request Test Coverage Report for Build 11069021382Details
💛 - Coveralls |
dasanra
approved these changes
Sep 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #446
How this PR fixes it
SafeFactoryclassSafeclass:#addPreValidatedSignature: Adds a PreValidatedSignature to the transaction if the threshold is not reached.#isReadyToExecute: Checks if the transaction has enough signatures to be executed.deployfunction in theSafeclass.getSafeAddressFromDeploymentTxutil function: Returns the address of a SafeProxy from the deployment tx receipt.Previous PR reference
#905
#948