feat(sdk): implement official CBOR based metadata #96
Conversation
iamcrazycoder
changed the title
| @@ -30,6 +30,7 @@ | |||
| "bitcoinjs-lib": "6.1.3", | |||
| "bitcoinjs-message": "2.2.0", | |||
| "buffer-reverse": "^1.0.1", | |||
| "cbor-js": "^0.1.0", | |||
There was a problem hiding this comment.
Can we replace it with this? https://www.npmjs.com/package/cbor
chor-js was last released 8 years ago.
|
@iamcrazycoder Hello, I think this feature is very good. Can I merge it into the main branch and publish a version to the npm repository as soon as possible? |
|
@yubing744 we cannot merge it yet as it will break some of our metadata. So we put it on hold, not our priority atm. But please feel free to fork it if needed. thank you! |
OK, I forked this project and wrote another PR to temporarily meet the needs of our bitseed project. |
|
Thank you @yubing744! We will reach out once we need to work on this. It's on our timeline |
What this PR does / why we need it:
This PR implements the the official CBOR-based metadata. Once merged, Ordit-SDK will be bidding goodbye to OIP-1.