m4: Only expose what GNU gettext also exposes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise gettext-tiny m4 libs ends up overriding other versions of vendored gnulib, making autoreconf fail. Additionally I checked that each m4 file has it's required automake functions, which can be listed with the following command: $ grep AC_REQUIRE m4/*.m4 | grep AM
|
this makes autoreconf -i fail on weechat 3.0 tarball. |
|
Turns out fixing autopoint unbreaks autoreconf on sed-4.9 (the reason I made this patch).
That said, it might be interesting to update the M4 files to a more recent version as it seems to be less involved.
For reference the error I had with sed-4.9:
```
+ cat /var/tmp/portage/sys-apps/sed-4.9-r1/temp/autoconf.out
***** autoconf *****
***** PWD: /var/tmp/portage/sys-apps/sed-4.9-r1/work/sed-4.9
***** autoconf --force
configure.ac:30: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:30: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
m4/threadlib.m4:36: gl_THREADLIB_EARLY_BODY is expanded from...
m4/threadlib.m4:29: gl_THREADLIB_EARLY is expanded from...
m4/gnulib-comp.m4:34: gl_EARLY is expanded from...
configure.ac:30: the top level
configure.ac:31: warning: gl_PTHREADLIB is m4_require'd but not m4_defun'd
m4/setlocale_null.m4:7: gl_FUNC_SETLOCALE_NULL is expanded from...
m4/gnulib-comp.m4:447: gl_INIT is expanded from...
configure.ac:31: the top level
configure.ac:31: warning: gl_PTHREADLIB is m4_require'd but not m4_defun'd
m4/mbrtowc.m4:8: gl_FUNC_MBRTOWC is expanded from...
m4/mbrlen.m4:7: gl_FUNC_MBRLEN is expanded from...
m4/gnulib-comp.m4:447: gl_INIT is expanded from...
configure.ac:31: the top level
configure.ac:31: warning: gl_PTHREADLIB is m4_require'd but not m4_defun'd
m4/mbrtowc.m4:8: gl_FUNC_MBRTOWC is expanded from...
m4/gnulib-comp.m4:447: gl_INIT is expanded from...
configure.ac:31: the top level
configure.ac:31: warning: gl_PTHREADLIB is m4_require'd but not m4_defun'd
m4/nl_langinfo.m4:7: gl_FUNC_NL_LANGINFO is expanded from...
m4/gnulib-comp.m4:447: gl_INIT is expanded from...
configure.ac:31: the top level
configure.ac:31: warning: gl_PTHREADLIB is m4_require'd but not m4_defun'd
m4/gnulib-comp.m4:447: gl_INIT is expanded from...
configure.ac:31: the top level
configure:7935: error: possibly undefined macro: gl_ANYTHREADLIB_EARLY
If this token and others are legitimate, please use m4_pattern_allow.
See the Autoconf documentation.
configure:11941: error: possibly undefined macro: gl_PTHREADLIB
configure:12026: error: possibly undefined macro: gl_WEAK_SYMBOLS
```
|
|
the optimal solution would be to ship only the m4 macros that are expected to be provided by autopoint, but strip them to the bare minimum without depending on the whole gnulib junk. |
|
@lanodan does the PR i just merged fix this (sed-4.9) issue for you ? |
|
does the PR i just merged fix this (sed-4.9) issue for you ?
Yeah, thanks for merging it.
the optimal solution would be to ship only the m4 macros that are expected to be provided by autopoint, but strip them to the bare minimum without depending on the whole gnulib junk.
Right, started this, will likely take a bit of time. At least with autopoint fixed it should be easy to drop gnulib in for quick workarounds.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise gettext-tiny m4 libs ends up overriding other versions
of vendored gnulib, making autoreconf fail.
Additionally I checked that each m4 file has it's required
automake functions, which can be listed with the following command:
$ grep AC_REQUIRE m4/*.m4 | grep AM