Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new campaign to facilitate instant distribution of assets #380

Closed
wants to merge 1 commit into from

Conversation

smol-ninja
Copy link
Member

@smol-ninja smol-ninja commented Jul 25, 2024

Changelog

Requesting @andreivladbrg and @PaulRBerg to leave your comments if you have other suggestions.

Alternate possibilities

  • If we wish to make no changes at all to the Merkle Lockup contracts, then another solution would be to duplicate the common code inside SablierMerkleInstant itself.
  • If we are going to deploy SablierMerkleInstant in the next release and not prior to that, then we can also change the API structure for SablierV2MerkleLL and SablierV2MerkleLT such that Lockup specific variables (cancelable and transferable) can be removed from the common constructer parameters, as they are not relevant to Merkle Instant contract.

Pending

  • Tests

@smol-ninja smol-ninja marked this pull request as draft July 25, 2024 12:53
andreivladbrg

This comment was marked as duplicate.

@PaulRBerg

This comment was marked as resolved.

@smol-ninja
Copy link
Member Author

Closing this and will re-open in core repo.

@smol-ninja smol-ninja closed this Jul 30, 2024
@smol-ninja smol-ninja deleted the feat/SablierMerkleInstant branch July 30, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants