Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor CreateMerkle scripts to deploy merkle lockup instances #374

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

smol-ninja
Copy link
Member

The objective of having CreateMerkleLL and CreateMerkleLT scripts is to deploy instances of merkle lockup and verify them on-chain so that etherscan can automatically verify other lockups deployed by the users.

However, its time consuming to construct the parameters of run command. This PR makes it easier to achieve the same objective by setting all parameters inside the script itself.

FOUNDRY_PROFILE=optimized \
forge script script/CreateMerkleLL.s.sol \
--broadcast --etherscan-api-key $ETHERSCAN_API_KEY \
--rpc-url mainnet --sig "run()" \
--verify -vvv

Copy link
Member

@andreivladbrg andreivladbrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we merge these two? Or add a new one CreateMerkleCampaigns to deploy both LL and LT in a single run. wdyt?

@andreivladbrg andreivladbrg mentioned this pull request Jul 22, 2024
@smol-ninja
Copy link
Member Author

Etherscan verification is not totally reliable so I'd keep them separate. If combined into a single run and one of the verifications fails, it would add a bit of a work to re-run one script while skipping the other.

@andreivladbrg
Copy link
Member

Got it, thanks for explaining

@andreivladbrg andreivladbrg merged commit 91ca871 into main Jul 22, 2024
7 checks passed
@smol-ninja smol-ninja deleted the refactor/CreateMerkle-scripts branch July 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants