refactor: dry-fy functions #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreivladbrg
force-pushed
the
refactor/dry-fy-functions
branch
from
828411d
to
564cf77
Compare
andreivladbrg
changed the base branch from
refactor/disable-sender-to-withdraw
to
2.1
Pushed now a commit. Lmk if you like this change |
Merged
refactor: dry-fy renounce function
andreivladbrg
force-pushed
the
refactor/dry-fy-functions
branch
from
564cf77
to
6a3ae61
Compare
PaulRBerg
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Great idea. PR looks good!
I also can't remember why we haven't written the functions like this in the first place. Perhaps we just didn't notice the potential optimization.
Happy to merge the PR as is, but as a precaution I suggest running the deep CI with a high number of fuzz runs after merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to dry fy
withdrawandrenounce. I couldn't find/remember why we didn't make this change earlier but I consider now that the code has been improved.If you have a valid argument against this change I am happy to give up on this PR.
Note: I am aware that we are checking twice the caller in
withdrawMaxAndTransfer. Don't think is worth to optimize since this function is very rarely used.