-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement renounceMultiple
#1061
base: staging
Are you sure you want to change the base?
Conversation
* test: Increase testing of multi renounce in dynamic, linear, and segmented situations. * docs: Add renounceMultiplet.tree
renounceMultiple
Great PR @cxp-13. There are some merge conflicts. Can you please resolve them and update the PR? Thank you. |
I merged the staging branch on my own branch, and only a few files were in conflict. I fixed them, but why are there so many file modifications when I submit them. My own branch cxp-13-feat/renouncemultimultiple is created based on the main branch. |
I'd recommend to reset your local branch with the $ git branch temp
$ git reset --hard origin/staging
$ git cherry-pick your_commit |
When I first cloned and implemented this feature, the total compiled files were less than 200. At that time, it could be successfully compiled. |
I understand what you mean, but I have already tried merging and submitting. Can we do this again? |
Great, this method can compile successfully. |
@cxp-13 before we review it, I'd appreciate if you can fix the failing CI. In case you ain't aware of the Bulloak, you can find details about it in the contributing guidelines. |
I look the guide(https://github.com/alexfertel/bulloak?tab=readme-ov-file#installation). but it didn't show where the warn at the file. |
My change don't involved the |
Don't worry about failing fork tests on CI. They don't work on PRs created by external contributors. We are still looking for a solution for that. |
Closes #1052
Added
renounceMultiple
to the contract sectionChanged
Tests:
renounceMultiple
under specific circumstances