ref: replace List.get with List.getOrNull

The latter is more readable imo
saber-notes · Sep 29, 2024 · 548787a · 548787a
1 parent 09ee13a
commit 548787a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/lib/components/canvas/canvas_preview.dart b/lib/components/canvas/canvas_preview.dart
@@ -2,7 +2,6 @@ import 'dart:async';
 
 import 'package:flutter/material.dart';
 import 'package:saber/components/canvas/inner_canvas.dart';
-import 'package:saber/components/home/grid_folders.dart';
 import 'package:saber/data/editor/editor_core_info.dart';
 import 'package:saber/data/editor/page.dart';
 import 'package:saber/data/extensions/list_extensions.dart';

diff --git a/lib/components/home/grid_folders.dart b/lib/components/home/grid_folders.dart
@@ -49,7 +49,8 @@ class GridFolders extends StatelessWidget {
         crossAxisCount: crossAxisCount,
         mainAxisSpacing: 8,
         itemBuilder: (context, index) {
-          final cardType = extraCards.get(index, _FolderCardType.realFolder);
+          final cardType =
+              extraCards.getOrNull(index) ?? _FolderCardType.realFolder;
           final folderName = cardType == _FolderCardType.realFolder
               ? folders[index - extraCards.length]
               : null;

diff --git a/lib/data/extensions/list_extensions.dart b/lib/data/extensions/list_extensions.dart
@@ -1,13 +1,4 @@
 extension ListExtensions<T> on List<T> {
-  D get<D extends T?>(int index, D defaultValue) {
-    assert(D == T || D == _typeOf<T?>());
-    if (index < 0 || index >= length) {
-      return defaultValue;
-    } else {
-      return this[index] as D;
-    }
-  }
-
   T? getOrNull(int index) {
     if (index < 0 || index >= length) {
       return null;
@@ -16,5 +7,3 @@ extension ListExtensions<T> on List<T> {
     }
   }
 }
-
-Type _typeOf<T>() => T;