Fix upstream Gohufont bug #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Ordinary questionmark and inverted questionmark in upstream Gohufont 14 have the same glyph name, breaking the font. [how] Rename the inverted questionmark to the customary "inverted" via ttx. This just prepares the change. Signed-off-by: Fini Jastrow <[email protected]>
Also clean up README situation. Fixes: #1652 Signed-off-by: Fini Jastrow <[email protected]>
|
Need to check the bitmaps before merging. |
|
Bitmaps are ok after PR.
In
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate the question mark and the inverted question mark in Gohufont 14.
They have the same glyph name in that font file and the wrong one is usually used.
The other becomes inaccessible.
See report in koemaeda/gohufont-ttf#3
Here we fix the source font file directly.
Requirements / Checklist
Issue number where discussion took place: #xxx
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Fixes: #1652
Screenshots (if appropriate or helpful)