Bugfix for Visual Studio 2022 #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finii
force-pushed
the
bugfix/visualstudio2022
branch
from
110e49a
to
7a95037
Compare
|
Forgot about the |
[why] Because the newer Preferred/Typographic names ID 16 and ID 17 have not a very demanding length limit we add the long form of the name addendum (i.e. Nerd Font, Nerd Font Mono, Nerd Font Propo). In the more restricted old names ID 1 and ID 2 we use the short forms (i.e. NF, NFM, NFP). This seems to be problematic with Visual Studio (Community) 2022 and the fonts can be selected but are not really used. The Postscript family name is never shortened which seems to be of no consequence, but still is different than the other. [how] When creating the Preferred/Typographic Family (ID 16) we check the shortening mode first and abbreviate the parts as needed and alike ID 1. This will also change the filenames, because they base on the SFNT table. We can not change that without changing the whole mechanism. [note] Also add new tool that lists all names of fonts, including the Postscript ones. Fixes: #1242 Signed-off-by: Fini Jastrow <[email protected]>
[why] It is better to have a not-abbreviated file name so that one can make sense out of the name parts, especially when doing a partial patch. With the previous commit we ended up with all abbreviated names. The filename length is hopefully not limited, at least not as severe as the SFNT table entries. [how] We need to store the answers somewhere because the naming is only understood by the FontnameParser object which we throw away soon. As fallback we still can parse the SFNT table, for example when the old renaming is used. Signed-off-by: Fini Jastrow <[email protected]>
Finii
force-pushed
the
bugfix/visualstudio2022
branch
from
7a95037
to
784e892
Compare
This was referenced Nov 16, 2023
Closed
LNKLEO
pushed a commit
to LNKLEO/Nerd
that referenced
this pull request
Nov 24, 2023
Bugfix for Visual Studio 2022
This was referenced Nov 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
name-parser: Unify abbreviations in family names
[why]
Because the newer Preferred/Typographic names ID 16 and ID 17 have not
a very demanding length limit we add the long form of the name
addendum (i.e. Nerd Font, Nerd Font Mono, Nerd Font Propo).
In the more restricted old names ID 1 and ID 2 we use the short forms
(i.e. NF, NFM, NFP).
This seems to be problematic with Visual Studio (Community) 2022 and the
fonts can be selected but are not really used.
The Postscript family name is never shortened which seems to be of no
consequence, but still is different than the other.
[how]
When creating the Preferred/Typographic Family (ID 16) we check the
shortening mode first and abbreviate the parts as needed and alike ID 1.
This will also change the filenames, because they base on the SFNT
table. We can not change that without changing the whole mechanism.
[note]
Also add new tool that lists all names of fonts, including the
Postscript ones.
Fixes: #1242
Requirements / Checklist
What does this Pull Request (PR) do?
How should this be manually tested?
Any background context you can provide?
What are the relevant tickets (if any)?
Screenshots (if appropriate or helpful)