Example and NaN fix #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on an example provided by Ryan in [1] [1]: ryankurte#1 (comment)
|
PR'd on the other end as stainless-steel/special#13. |
ryankurte
approved these changes
Nov 25, 2023
There was a problem hiding this comment.
lgtm (though i created a conflict by merging #3, soz)
PR'd on the other end as stainless-steel/special#13.
nice! no reason to block i think / can update when it's available
This resolves a merge conflict in Cargo.toml.
|
The conflict is resolved by merging the main branch into here. An extra change updates the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things in commits that should be independent enough that you can cherry-pick if you don't like the bundle:
cargo run --example osrngthat tests the OS's RNG and prints concrete outputs (and gives concrete example values to put into the block size).specialcrate.Big caveat that I only just found while doing further testing: Apparently the special crte does require alloc; checking to see if that can be made optional.