Improve filter callback API redux #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FenrirWolf
force-pushed
the
improve_filter_callback
branch
2 times, most recently
from
806851d
to
9ed5878
Compare
It's kinda pointless to have those checks *after* attempting to deref the data rather than before.
Trying to capture values by ref won't work for anything that's not `'static`
FenrirWolf
force-pushed
the
improve_filter_callback
branch
from
f657a94
to
7a84ce3
Compare
Meziu
approved these changes
Feb 23, 2024
ian-h-chamberlain
approved these changes
Feb 25, 2024
Comment on lines
+22
to
+23
| keyboard.set_filter_callback(Some(Box::new(move |str| { | ||
| if str.contains("boo") { |
There was a problem hiding this comment.
Huh, just realized I'm surprised there's no lint for shadowing builtin str, but I guess shadowing in general is not linted for so idk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that our code is in control of calling the software keyboard, we can switch away from using
CStrings in the filter callback without incurring extra allocations. Plus there's a lot of room to simplify the implementation overall, which I've been able to do here too.