Make Debug impl for FamStructWrapper print contents
#228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of re-interpreting the entire flexible array member contents as `T`, and then printing garbage, actually print out the FAM header, and then the _entries_ of the array. Tightens the bound on the `Debug` implementation to require `T::Entry: Debug` (as opposed to just `T: Debug`). Signed-off-by: Patrick Roy <[email protected]>
roypat
requested review from
liujing2,
sameo,
andreeaflorescu,
jiangliu and
ShadowCurse
as code owners
ShadowCurse
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of re-interpreting the entire flexible array member contents as
T, and then printing garbage, actually print out the FAM header, and then the entries of the array.Tightens the bound on the
Debugimplementation to requireT::Entry: Debug(as opposed to justT: Debug).Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.