-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-config: rename to config.toml #259
cargo-config: rename to config.toml #259
Conversation
Gentle ping :-) it's an easy one |
I don't think the symlink is needed :D
|
Good point :-D I'll remove the symlink!
|
9ff69d1
to
61ac5aa
Compare
v2:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: commit title still says "and add a symlink" (approving because you can update commit messages without dismissing approvals on github :)
cargo recently complains about our cargo configuration file name: $ cargo build warning: `vhost/.cargo/config` is deprecated in favor of `config.toml` note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml` As suggested, let's update the file name. We don't create the symlink since 2021 edition is not supported by 1.38 toolchain: $ cargo +1.38.0 build error: failed to parse manifest at `vhost/Cargo.toml` Caused by: failed to parse the `edition` key Caused by: supported edition values are `2015` or `2018`, but `2021` is unknown Signed-off-by: Stefano Garzarella <[email protected]>
61ac5aa
to
b641ced
Compare
uff, it's monday, no wait it's not ;-P fixed, thanks! :-) |
Summary of the PR
cargo recently complains about our cargo configuration file name:
As suggested, let's update the file name.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.