vhost: support for "standalone" vhost-user daemons #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsquad
force-pushed
the
standalone/get-specs
branch
from
b4313a1
to
caf306d
Compare
Although originally introduced for VDPA we also have support for get/set status messages for vhost-user. So lets promote the trait functions to the main VhostBackend traits while providing a default implementation which responds for errors (which the Kernel variant would inherit). As the status bits are common between backends most of the implementation details can be handled within the vhost-user traits. Signed-off-by: Alex Bennée <[email protected]> --- v2 - also add impls for DummySlaveReqHandler - move VhostVdpa impls to impl<T: VhostKernBackend> VhostBackend for T
This seems like an awful lot of boilerplate (without even any test) to implement a single message. Signed-off-by: Alex Bennée <[email protected]>
stsquad
force-pushed
the
standalone/get-specs
branch
from
caf306d
to
be83316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although originally introduced for VDPA we also want to support this for vhost-user. This requires supporting SET/GET status by moving the trait implementations around and a new message called BACKEND_SPECS which allows the backend to report its capabilities to the VMM as it boots up.
I suspect I need some extra handling for properly setting things like FEATURES_OK and DEVICE_NEED_RESET. And some tests of course. I shall be shortly posting the RFC patches for QEMU to support this. As such this will be a draft PR for comment for now.