protocol: Remove hardcoded page size #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbradford
reviewed
Jun 12, 2023
peng6662001
changed the title
peng6662001
changed the title
sboeuf
approved these changes
Jun 13, 2023
|
@sameo Please review this patch. |
peng6662001
changed the title
rbradford
approved these changes
Jun 28, 2023
|
Please fix the quality checks and update your commit. |
@rbradford Fixed |
Signed-off-by: dom.song <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The hardcode of 4096 only works well on kernel with CONFIG_ARM64_4K_PAGES=y,when the kernel's config is CONFIG_ARM64_64K_PAGES=y,vfio-user works fail.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.