-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce RISC-V architecture support #190
Introduce RISC-V architecture support #190
Conversation
b14019c
to
05c0d12
Compare
3d64381
to
8a465c5
Compare
@roypat @rbradford @ShadowCurse PTAL when convenient :) |
8a465c5
to
e8a636f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like there is a lot of code duplicated between the ARM and RISC implementations that doesn't really need to be duplicated like this. Can you have a look at that, to see where we can reuse instead? :o
Yes, I noticed that, I just copied these files incase there is something to be diverged in the future I can try to merge the common part as possible, but what should we name that, like |
Maybe move the fdt code to a higher level and then |
Add binary used to test loader on `riscv64` platform. Signed-off-by: Ruoqing He <[email protected]>
Fix wrongly put rust-vmm#197 changelog and add entry for rust-vmm#190. Signed-off-by: Ruoqing He <[email protected]>
e8a636f
to
f23d1cb
Compare
Fix wrongly put rust-vmm#197 changelog and add entry for rust-vmm#190. Signed-off-by: Ruoqing He <[email protected]>
f23d1cb
to
29e3740
Compare
Fix wrongly put rust-vmm#197 changelog and add entry for rust-vmm#190. Signed-off-by: Ruoqing He <[email protected]>
29e3740
to
36c2b55
Compare
RISC-V uses the same image format ARM64 did, reuse the PE image loader and add support for loading a `riscv64` PE image. Signed-off-by: Ruoqing He <[email protected]>
Enable `fdt` module in `configurator` on riscv64 architecture. Signed-off-by: Ruoqing He <[email protected]>
As clippy command in our CI mandates: `cargo clippy --workspace --bins --examples --benches --all-features --all-targets -- -D warnings -D clippy::undocumented_unsafe_blocks`, add benchmarck test to appease clippy. Signed-off-by: Ruoqing He <[email protected]>
Add entries to document newly introduced support for riscv64. Signed-off-by: Ruoqing He <[email protected]>
As `rustfmt` suggested, `config` is deprecated, moving to `config.toml`. Signed-off-by: Ruoqing He <[email protected]>
Add `.platform` file to enable x86_64, aarch64, riscv64 CI. Signed-off-by: Ruoqing He <[email protected]>
Fix wrongly put rust-vmm#197 changelog and add entry for rust-vmm#190. Signed-off-by: Ruoqing He <[email protected]>
36c2b55
to
90670bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the refactoring this change is lovely and compact.
Summary of the PR
Introduce RISC-V architecture to
loader
, bringing #163 forward.Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s
), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafe
code is properly documented.