Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump windows-sys to 0.59.0 #369

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chantra
Copy link

@chantra chantra commented Oct 2, 2024

Simple windows-sys version bump to the latest published crate version.

@Wojtek242
Copy link
Collaborator

Hi @chantra, thanks for the PR, but based on the build outputs: https://github.com/rust-pcap/pcap/actions/runs/11135749919/job/32117440201?pr=369 you will need to ammend the code as well. Let me know if you need help.

You can ignore the lints as that is currently also a problem on main.

@chantra
Copy link
Author

chantra commented Oct 27, 2024

Thanks @Wojtek242 ,

I will update the PR accordingly. I think that now that you authorized this PR to run the GitHub actions, update should do too, so this may help. I don’t have a windows setup handy, but I am fairly confident I should be able to cross-compile easily with cargo.

Since windows-sys-0.45.0,
`windows_sys::Win32::Networking::WinSock::ADDRESS_FAMILY` are u16 instead
of u32.
@chantra
Copy link
Author

chantra commented Oct 28, 2024

@Wojtek242 ok, it seems I can't get the CI to run without approval.

This now builds with:

cargo build --target=x86_64-pc-windows-gnu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants