Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #128577

Closed
wants to merge 42 commits into from
Closed

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    0d49862 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6d477d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    84d84da View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Enable std::io::copy specialisation for `std::pipe::{PipeReader, Pi…

    …peWriter}`
    
    Signed-off-by: Jiahao XU <[email protected]>
    NobodyXu committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    649b431 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    794434e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d8211de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f6f0ef4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    12d87ee View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f91da72 View commit details
    Browse the repository at this point in the history
  6. Move a comment.

    In rust-lang#125443 this comment ended up in the wrong spot. I'm not sure why;
    after careful checking this was the only case I could find like this.
    nnethercote committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    bd24763 View commit details
    Browse the repository at this point in the history
  7. Insert some blank lines.

    After things that are immediately followed by a `use` declaration and
    look like they might apply to that `use` item but actually don't.
    nnethercote committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    70fcf9e View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    bd23e0e View commit details
    Browse the repository at this point in the history
  2. Inline and remove parse_local_mk.

    It has a single use. This makes the `let` handling case in
    `parse_stmt_without_recovery` more similar to the statement path and
    statement expression cases.
    nnethercote committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    281c2fd View commit details
    Browse the repository at this point in the history
  3. Remove LhsExpr.

    `parse_expr_assoc_with` has an awkward structure -- sometimes the lhs is
    already parsed. This commit splits the post-lhs part into a new method
    `parse_expr_assoc_rest_with`, which makes everything shorter and
    simpler.
    nnethercote committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    fe647f0 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Streamline attribute stitching on AST nodes.

    It can be done more concisely.
    nnethercote committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    2eb2ef1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d77d17 View commit details
    Browse the repository at this point in the history
  3. Distinguish the two kinds of token range.

    When collecting tokens there are two kinds of range:
    - a range relative to the parser's full token stream (which we get when
      we are parsing);
    - a range relative to a single AST node's token stream (which we use
      within `LazyAttrTokenStreamImpl` when replacing tokens).
    
    These are currently both represented with `Range<u32>` and it's easy to
    mix them up -- until now I hadn't properly understood the difference.
    
    This commit introduces `ParserRange` and `NodeRange` to distinguish
    them. This also requires splitting `ReplaceRange` in two, giving the new
    types `ParserReplacement` and `NodeReplacement`. (These latter two names
    reduce the overloading of the word "range".)
    
    The commit also rewrites some comments to be clearer.
    
    The end result is a little more verbose, but much clearer.
    nnethercote committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d1f05fd View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b485dd1 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    94da7b1 View commit details
    Browse the repository at this point in the history
  6. Revert "Rollup merge of rust-lang#128104 - mu001999-contrib:fix/12805…

    …3, r=petrochenkov"
    
    This reverts commit 91b18a0, reversing
    changes made to 9aedec9.
    compiler-errors committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3e0f186 View commit details
    Browse the repository at this point in the history
  7. Revert "Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enha…

    …nce, r=pnkfelix"
    
    This reverts commit a70dc29, reversing
    changes made to ceae371.
    compiler-errors committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6cd4315 View commit details
    Browse the repository at this point in the history
  8. Revert "Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enha…

    …nce-2, r=pnkfelix"
    
    This reverts commit 31fe962, reversing
    changes made to f203078.
    compiler-errors committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b0ca61f View commit details
    Browse the repository at this point in the history
  9. Revert "Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enha…

    …nce, r=pnkfelix"
    
    This reverts commit 2724aea, reversing
    changes made to d929a42.
    compiler-errors committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    89e0587 View commit details
    Browse the repository at this point in the history
  10. Revert "Rollup merge of rust-lang#126315 - mu001999-contrib:fix/12628…

    …9, r=petrochenkov"
    
    This reverts commit 977c5fd, reversing
    changes made to 24c94f0.
    compiler-errors committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    02f4762 View commit details
    Browse the repository at this point in the history
  11. Revert "Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enha…

    …nce, r=pnkfelix"
    
    This reverts commit 13314df, reversing
    changes made to 6e534c7.
    compiler-errors committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d51b4bc View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    9a6133b View commit details
    Browse the repository at this point in the history
  13. Add the sha512, sm3 and sm4 target features

    Add the feature in `core/lib.rs`
    sayantn committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    41b017e View commit details
    Browse the repository at this point in the history
  14. Bless test fallout

    compiler-errors committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    0142573 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    c0d9357 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    560e86d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    290a260 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    84e261e View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Rollup merge of rust-lang#126704 - sayantn:sha, r=Amanieu

    Added SHA512, SM3, SM4 target-features and `sha512_sm_x86` feature gate
    
    This is an effort towards rust-lang#126624. This adds support for these 3 target-features and introduces the feature flag `sha512_sm_x86`, which would gate these target-features and the yet-to-be-implemented detection and intrinsics in stdarch.
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    c7b684e View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#127095 - Oneirical:testiary-education, r=ji…

    …eyouxu
    
    Migrate `reproducible-build-2` and `stable-symbol-names` `run-make` tests to rmake
    
    Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
    
    Needs try-jobs.
    
    try-job: x86_64-msvc
    try-job: armhf-gnu
    try-job: test-various
    try-job: aarch64-apple
    try-job: i686-msvc
    try-job: x86_64-mingw
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    83ba819 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#127586 - zachs18:more-must-use, r=cuviper

    Add `#[must_use]` to some `into_raw*` functions.
    
    cc rust-lang#121287
    
    r? `@cuviper`
    
    Adds `#[must_use = "losing the pointer will leak memory"]`[^1] to `Box::into_raw(_with_allocator)`, `Vec::into_raw_parts(_with_alloc)`, `String::into_raw_parts`[^2], and `rc::{Rc, Weak}::into_raw_with_allocator` (Rc's normal `into_raw` and all of `Arc`'s `into_raw*`s are already `must_use`).
    
    Adds `#[must_use = "losing the raw <resource name may leak resources"]` to `IntoRawFd::into_raw_fd`, `IntoRawSocket::into_raw_socket`, and `IntoRawHandle::into_raw_handle`.
    
    [^1]: "*will* leak memory" may be too-strong wording (since `Box`/`Vec`/`String`/`rc::Weak` might not have a backing allocation), but I left it as-is for simplicity and consistency.
    
    [^2]: `String::into_raw_parts`'s `must_use` message is changed from the previous (possibly misleading) "`self` will be dropped if the result is not used".
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    c88a0a7 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#128161 - EtomicBomb:just-compiletest, r=not…

    …riddle
    
    nested aux-build in tests/rustdoc/ tests
    
    * Fixes bug that prevented using nested aux-build in `tests/rustdoc/` tests. Before, `fn document` and the auxiliary builder disagreed about where to find the nested aux-build source file (`auxiliary/auxiliary/aux.rs` vs `auxiliary/aux.rs`), preventing them from building. Picked the latter in line with other builders in compiletest.
    * Adds `//@ doc-flags` header, which forwards flags to rustdoc and not rustc.
    * Adds `//@ unique-doc-out-dir` header, which sets the --out-dir for the rustdoc invocation to a unique directory: `<root out dir>/docs/<test name>/doc`
    * Changes working directory of the rustdoc invocation to the root out directory (common among all aux-builds). Prior art: exec_compiled_test in runtest.rs
    * Adds tests that use nested aux builds and new headers
    
    These changes provide useful capabilities for writing rustdoc tests on their own. They are also needed to test the implementation for the [mergable-rustdoc-cross-crate-info](rust-lang/rfcs#3662) RFC.
    
    try-job: x86_64-msvc
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    20b65ae View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#128303 - NobodyXu:specialise-for-pipe, r=cu…

    …viper
    
    Enable `std::io::copy` specialisation for `std::pipe::{PipeReader, PipeWriter}`
    
    Enable `std::io::copy` specialisation on unix for the newly added anonymous pipe API, tracking issue rust-lang#127154
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    d33d31b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=j…

    …ieyouxu
    
    Migrate `cross-lang-lto-clang` and `cross-lang-lto-pgo-smoketest` `run-make` tests to rmake
    
    Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html).
    
    This has the same problem outlined by rust-lang#126180, where the tests do not actually run as no test-running CI enviroment has `RUSTBUILD_FORCE_CLANG_BASED_TESTS` set.
    
    However, I still find it interesting to turn the Makefiles into the rmake format until the Clang issue is fixed.
    
    This should technically be tested on MSVC... if MSVC actually ran Clang tests.
    
    try-job: x86_64-gnu-debug
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    b3ebd3b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#128368 - nnethercote:rustfmt-tweaks, r=cuviper

    Formatting tweaks
    
    Some small post-rust-lang#125443 formatting tweaks.
    
    r? `@cuviper`
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    8364347 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#128404 - compiler-errors:revert-dead-code-c…

    …hanges, r=pnkfelix
    
    Revert recent changes to dead code analysis
    
    This is a revert to recent changes to dead code analysis, namely:
    * efdf219 Rollup merge of rust-lang#128104 - mu001999-contrib:fix/128053, r=petrochenkov
    * a70dc29 Rollup merge of rust-lang#127017 - mu001999-contrib:dead/enhance, r=pnkfelix
    * 31fe962 Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
    * 2724aea Rollup merge of rust-lang#126618 - mu001999-contrib:dead/enhance, r=pnkfelix
    * 977c5fd Rollup merge of rust-lang#126315 - mu001999-contrib:fix/126289, r=petrochenkov
    * 13314df Rollup merge of rust-lang#125572 - mu001999-contrib:dead/enhance, r=pnkfelix
    
    There is an additional change stacked on top, which suppresses false-negatives that were masked by this work. I believe the functions that are touched in that code are legitimately unused functions and the types are not reachable since this `AnonPipe` type is not publically reachable -- please correct me if I'm wrong cc ````@NobodyXu```` who added these in #rust-lang#127153.
    
    Some of these reverts (rust-lang#126315 and rust-lang#126618) are only included because it makes the revert apply cleanly, and I think these changes were only done to fix follow-ups from the other PRs?
    
    I apologize for the size of the PR and the churn that it has on the codebase (and for reverting ````@mu001999's```` work here), but I'm putting this PR up because I am concerned that we're making ad-hoc changes to fix bugs that are fallout of these PRs, and I'd like to see these changes reimplemented in a way that's more separable from the existing dead code pass. I am happy to review any code to reapply these changes in a more separable way.
    
    cc ````@mu001999````
    r? ````@pnkfelix````
    
    Fixes rust-lang#128272
    Fixes rust-lang#126169
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    a966ede View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#128483 - nnethercote:still-more-cfg-cleanup…

    …s, r=petrochenkov
    
    Still more `cfg` cleanups
    
    Found while looking closely at `cfg`/`cfg_attr` processing code.
    
    r? ````````@petrochenkov````````
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    47099a8 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#128557 - nyurik:dup-init, r=compiler-errors

    chore: use shorthand initializer
    
    Tiny readability improvement - don't use redundant initializer vars
    jieyouxu authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    31db40d View commit details
    Browse the repository at this point in the history