Include extra information in metadata comments #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the
merge_sha
in BuildFailed, TryBuildFailed, and TimedOut metadata comments.This helps with synchronizing historical data, and will help in the future correlating which build a failure is associated with.
Also include
started_at
orended_at
in all build-related comments.Timing information could be gleaned from comment times, but make it explicit in the metadata. This means we can get the true times, even if GitHub has delays.
This also gives us the opportunity to have more control in the future. For example, the check_run event includes
started_at
andcompleted_at
information that is independent from when GitHub sent us the webhook.There are no visible changes to any of the comments.
Example success:
Example timeout:
Example failure: