Eliminate the use of public_test_dep!
#656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some CI will fail until parts of #652 land. |
Replace `public_test_dep!` by placing optionally public items into new modules, then controlling what is exported with the `public-test-deps` feature. This is nicer for automatic formatting and diagnostics.
tgross35
force-pushed
the
public-test-deps
branch
from
2c3ed0b
to
2e2a925
Compare
|
It looks like this created some surprising inference at rust-lang/rust#128691 (comment). I don't really understand why, asked on Zulip https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/Associated.20type.20suggestions. The other change is more pressing to get into the main repo, so I am just going to revert this and revisit later. |
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
public_test_dep!by placing optionally public items into new modules, then controlling what is exported with thepublic-test-depsfeature.This is nicer for automatic formatting and diagnostics.