Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic unorddf2vfp() and unordsf2vfp() #626

Closed
wants to merge 2 commits into from

Conversation

sbechet
Copy link
Contributor

@sbechet sbechet commented May 29, 2024

A (weak) contribution to trying to understand this great project.

@Amanieu
Copy link
Member

Amanieu commented May 30, 2024

Since these only exist on ARM, please mark them with #[cfg(target_arch = "arm")].

@sbechet
Copy link
Contributor Author

sbechet commented May 31, 2024

Since these only exist on ARM, please mark them with #[cfg(target_arch = "arm")].

You right. I will correct that. Before I submit an update are we ok about check boxes. I ask the question because I saw that certain boxes were not checked for certain functions even though the generic version of the code exists.

@Amanieu
Copy link
Member

Amanieu commented Jun 22, 2024

I double-checked the *vfp functions and it turns out that they are only used on old versions of 32-bit iOS with ARMv5. Since we don't support this in any current target, we can probably just remove all the *vfp functions.

@sbechet
Copy link
Contributor Author

sbechet commented Jun 22, 2024

That's perfect, in this case, I can close this pull request without further delay.
Are you interested in a pull request to update the README and deprecate all these functions or will you do it? There must not be much left to do in this project I imagine?

@Amanieu
Copy link
Member

Amanieu commented Jul 6, 2024

Yes, I would be interested in a PR to update the README and remove all the existing *vfp functions since they serve no purpose.

@tgross35
Copy link
Contributor

@sbechet since we probably don't need this change as-is I am just going to close this PR. Feel free to create a new one that removes the symbols as mentioned above.

@tgross35 tgross35 closed this Aug 22, 2024
tgross35 pushed a commit that referenced this pull request Sep 4, 2024
Remove all *vfp functions and related tests since LLVM no longer emits them.

Link: #626

[ Reword commit message - Trevor ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants