Add f128 float to integer conversion functions
#613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
f16-f128-convert
branch
3 times, most recently
from
642d082
to
568377b
Compare
tgross35
changed the title
f16 and f128 conversion functionsf128 float to integer conversion functions
|
I think this one should be all set now |
Amanieu
reviewed
May 20, 2024
testcrate/build.rs
Outdated
| } | ||
|
|
||
| if target.starts_with("i586") { | ||
| // i586 seems to not have ``__fixunstfti`, but does have everything else |
There was a problem hiding this comment.
It's strange that this is only missing for i586 but not i686 since they should both be linking to the same libgcc. Are the docker images using different package versions for these 2 targets?
There was a problem hiding this comment.
It just didn't show up because i686 was already disabled a few lines up due to an ABI issue https://github.com/rust-lang/compiler-builtins/pull/613/files#diff-05ae0211bd995d6870067db299c32944cf2b743226442889bb07d48232afc2c5R22-R24. Interesting, I guess that specific issue must not be a problem on i586.
I explicitly listed i586 here to be clear.
Deduplicate code used for float to integer conversions in order to make adding `f128` conversion functions easier.
tgross35
force-pushed
the
f16-f128-convert
branch
from
568377b
to
4d9b827
Compare
`as` casts are only allowed for primitives, doing the same operations with `rustc_apfloat` requires using functions. Add a way to specify these separately.
Add the following: - `__fixtfsi` - `__fixtfdi` - `__fixtfti` - `__fixunstfsi` - `__fixunstfdi` - `__fixunstfti`
tgross35
force-pushed
the
f16-f128-convert
branch
from
4d9b827
to
4edcd5a
Compare
84 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the following:
__fixtfsi__fixtfdi__fixtfti__fixunstfsi__fixunstfdi__fixunstfti