Add tests for verbatim paths on windows builds #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terminology note: rust calls these "verbatim" paths. A UNC path is technically one in the form:
A bit more about this here: https://users.rust-lang.org/t/understanding-windows-paths/58583 |
theKidOfArcrania
changed the title
noted |
|
hmm... it looks the gnu toolchain does not support verbatim paths? Should we disable verbatim tests for the *-windows-gnu targets? |
Amanieu
reviewed
May 16, 2024
|
Ok I think all the changes have been made and should be good to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds test building for windows targets if
--target-dirgets set to a verbatim path. This is due to the fact that verbatim or verbatim unc paths have an additional requirement of having all path separators to be backslashes as opposed to be permissive of forward and back slashes.This was made in response to #609 / #604.