Skip to content

Commit

Permalink
Ignore broken nightly/system builtins
Browse files Browse the repository at this point in the history
  • Loading branch information
beetrees committed Jun 30, 2024
1 parent 367ba35 commit 01a7c0c
Showing 1 changed file with 13 additions and 3 deletions.
16 changes: 13 additions & 3 deletions testcrate/src/bench.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ pub fn skip_sys_checks(test_name: &str) -> bool {
"extend_f16_f32",
"trunc_f32_f16",
"trunc_f64_f16",
// FIXME(f16_f128): rounding error
// FIXME(#616): re-enable once fix is in nightly
// <https://github.com/rust-lang/compiler-builtins/issues/616>
"mul_f128",
"mul_f32",
"mul_f64",
];

// FIXME(f16_f128): error on LE ppc64. There are more tests that are cfg-ed out completely
Expand All @@ -29,7 +30,12 @@ pub fn skip_sys_checks(test_name: &str) -> bool {

// FIXME(f16_f128): system symbols have incorrect results
// <https://github.com/rust-lang/compiler-builtins/issues/617#issuecomment-2125914639>
const X86_NO_SSE_SKIPPED: &[&str] = &["add_f128", "sub_f128", "powi_f32", "powi_f64"];
const X86_NO_SSE_SKIPPED: &[&str] =
&["add_f128", "sub_f128", "mul_f128", "powi_f32", "powi_f64"];

// FIXME(f16_f128): Incorrect rounding.
// <https://github.com/llvm/llvm-project/issues/91840>
const AARCH64_SKIPPED: &[&str] = &["mul_f128"];

// FIXME(llvm): system symbols have incorrect results on Windows
// <https://github.com/rust-lang/compiler-builtins/issues/617#issuecomment-2121359807>
Expand Down Expand Up @@ -61,6 +67,10 @@ pub fn skip_sys_checks(test_name: &str) -> bool {
return true;
}

if cfg!(target_arch = "aarch64") && AARCH64_SKIPPED.contains(&test_name) {
return true;
}

if cfg!(target_family = "windows") && WINDOWS_SKIPPED.contains(&test_name) {
return true;
}
Expand Down

0 comments on commit 01a7c0c

Please sign in to comment.