Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating archives with members from an import library #17

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

dpaoliello
Copy link
Contributor

Currently the default object reader can't handle getting symbols from an import library archive member, and so symbols from such members are not included in the symbol table for the archive, resulting in linker failures.

This change:

  • Adds a fallback to the default object reader to try parsing a member as an import library if normal parsing fails.
  • Adds a test to wrap an import library in an archive (and compare to lib.exe).
  • Bumps the version of object so that the EC Symbol Table is correct skipped.

@bjorn3 bjorn3 merged commit ac1da45 into rust-lang:master Aug 1, 2024
2 checks passed
@bjorn3
Copy link
Member

bjorn3 commented Aug 1, 2024

Thanks! Published as v0.3.2.

@dpaoliello dpaoliello deleted the parseimp branch August 1, 2024 16:39
@klensy
Copy link

klensy commented Aug 2, 2024

version = "0.3.1"

Version still 0.3.1 in Cargo.toml.

@bjorn3
Copy link
Member

bjorn3 commented Aug 2, 2024

I had pushed the v0.3.2 tag, but forgot to push it to the master branch too. Done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants