Removed unused options (deterministic, symbol table) #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Apr 9, 2024
dpaoliello
changed the title
|
Would you mind bumping the crate version to 0.2.0 to ensure it doesn't accidentally get published as a 0.1 release? |
… use settings that the Rust compiler needs
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Rust compiler always sets deterministic and enables symbol tables therefore, to simplify both the code and tests, they are the only options that will be supported.
Note that this will make syncing to the latest LLVM sources a bit more difficult, but it shouldn't be too bad since it doesn't significantly change the shape of the code.