Reorg the transaction module #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
koushiro
commented
Feb 17, 2024
koushiro
commented
- split the transaction module to legacy/eip2930/eip1559 modules
- add to_message method for LegacyTransaction/EIP2930Transaction/EIP1559Transaction
- adjust some imports
|
@sorpaas PTAL |
- split the transaction module to legacy/eip2930/eip1559 modules - add to_message method for LegacyTransaction/EIP2930Transaction/EIP1559Transaction - adjust some imports
koushiro
force-pushed
the
reorg-transaction
branch
from
fa02f4c
to
063d03b
Compare
sorpaas
reviewed
Feb 18, 2024
src/block.rs
Outdated
| util::ordered_trie_root, EnvelopedDecodable, EnvelopedEncodable, Header, PartialHeader, | ||
| TransactionAny, TransactionV0, TransactionV1, TransactionV2, | ||
| }; | ||
| #[cfg(not(feature = "std"))] |
There was a problem hiding this comment.
This is unnecessary. alloc is also available in no_std.
So I would prefer we just always do use alloc::vec::Vec regardless of std or no_std.
Same for all below.
sorpaas
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.