Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved PublicKey and XOnlyPublicKey Debug impl #745

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

liamaharon
Copy link
Contributor

Closes #729

Adjusts Debug impls to write serialized hex representation of the keys rather than the inner u8 bytes.

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ca32f7b successfully ran local tests

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ca32f7b

@apoelstra apoelstra merged commit 736adc9 into rust-bitcoin:master Sep 17, 2024
30 checks passed
@apoelstra
Copy link
Member

Wow, you got your ACK in just seconds before I made the merge commit.

@liamaharon liamaharon deleted the publickey-debug-impl branch September 17, 2024 21:51
@tcharding
Copy link
Member

Like a boss!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PublicKey and XOnlyPublicKey should not *derive* Debug
3 participants