Fix CI #641
Fix CI #641
Conversation
|
I can't repro the ASAN memory sanitizer failure and have no clue what is causing it. |
|
The ASAN thing is extremely weird. "Undefined reference to |
|
After writing rust-bitcoin/rust-bitcoin#1981 there is a lot to do and we need this in to get cracking. Kick CI, no changes. |
|
When I try to run this test locally I get the error |
|
Strange you get the error still, it is allowed now (in a1005a6) I looked it up but didn't quite understand what it was for. I'll remove it. |
|
Removed, no other changes. |
|
Ok I can reproduce locally now :) |
I don't know what that commit is from. I don't have it locally. |
|
This is extremely weird. In my |
|
Ok, it's a problem in the |
|
The old |
|
rust-lang/cc-rs#780 is the offending PR, though I haven't looked into how yet. |
|
@tcharding let's just pin |
Pinning is broken again, update the pins it CI so that the following sequence of commands would work ```bash rm Cargo.lock cargo +1.48 update -p wasm-bindgen-test --precise 0.3.34 cargo +1.48 update -p serde_test --precise 1.0.175 cargo +1.48 test --all-features ``` Note, solely out of interest, `cargo +1.48 build` does not need pinning (at the moment :)
`cargo +nightly` output of panic recently changed breaking our grep statement by adding the code line and a newline. Grep for the exact second line of the error message.
Remove the `internal_features` attribute, not sure what it was supposed to be doing but the crate works without it.
We have an unconditional panic for some combination of features, this causes clippy to give a bunch of useless warnings. Add allow attributes to quieten down clippy.
Currently the panic message refers to stuff related to development of the library, this is meaningless for users of the lib. Target panic message at secp users instead.
In preparation for using `pushd`/`popd` use `bash` to run the CI script instead of `sh`.
Looks like a recent version of `cc` breaks our ASAN job. Pin to the previous version.
|
Took me a while, but oh yeah it works! |
|
Ok, testing locally, thanks so much! BTW I think the
It would be nice to test somehow the "we aren't pulling in std", but I think this is a weird enough failure mode that we shouldn't bend over backward to do it. |
CI has a bunch of things broken.
This is #640 followed by #639 followed by a few addition fixes to get CI green again. Includes clippy warnings in feature gated code which is not strictly necessary and a fix to a panic message, also not strictly necessary.