DEMO: Hack the plan module #750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `plan` module currently includes a method on `Plan` that takes a `psbt::Input` as parameter. We would like to be able to either deprecate or remove the `psbt` module. In order to do so we would need to solve this problem. Here is one quick and dirty solution: - Make the private `Plan` fields public - Delete the method and make a standalone function in `psbt-v0`
|
I would prefer a solution that just depended on |
|
Ha! I jumped out of bed this morning after having that exact thought, does that mean I'm brilliant or you are? |
|
Would you be open to adding public re-exports of Only if this whole thing gets traction though of course. |
|
Decided not to import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a merge candidate but is just an investigation of the benefits of having a new
psbt-v0crate.The
planmodule currently includes a method onPlanthat takes apsbt::Inputas parameter. We would like to be able to either deprecate or remove thepsbtmodule. In order to do so we would need to solve this problem. Here is one quick and dirty solution:Planfields publicpsbt-v0This is related to rust-bitcoin/rust-bitcoin#3210 and was created to test https://github.com/tcharding/rust-psbt-v0/pull/6 and bitcoindevkit/bdk#1621