-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative fes_to_bytes_zeropad with no dropping of last bits #201
Conversation
b0567fa
to
15f6d0e
Compare
In 15f6d0e: The change to the doccomment starting with "If the total number of bits" is wrong. (Though I agree this sentence is really long, and if you can break it up somehow, you should.) Otherwise ack. CI failure is unrelated and is fixed by #200 (which I will merge shortly, so you will just need to rebase). |
I changed the documentation, made the explanation more detailed. /// Similar to `fes_to_bytes`, but in this variant trailing bits are kept.
///
/// If the last bits do not fill up the last output byte completely, they
/// are not dropped, but kept, and the last byte is padded with zero bits.
/// In effect this is the same as if the input was padded with zero values
/// (1 or 2), such that there are enough zero bits to fill the last byte.
/// The output is either the same as of `fes_to_bytes`, or has 1 extra byte. |
639d20c
to
06762e0
Compare
New text looks great! Nah, I wouldn't bother squashing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 06762e0 successfully ran local tests
Will let @clarkmoody review before merging since this is an API change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 06762e0
Fixes #198 , as discussed there