benchmarks: restore benchmarks #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is just because nightly rustc has introduced a new |
tcharding
approved these changes
Mar 30, 2024
|
cc @clarkmoody this is a quick/easy PR. Can you do a quick review? Alternately, would you be okay with my merging things here with only ACKs from @tcharding? |
|
Needs api files updating @apoelstra |
|
Also I've emailed Clark to see what is the status here and on #180. |
Found with `cargo +nightly clippy --all-targets`.
In rust-bitcoin#128 we dropped the benchmarks. They can be restore with only minor tweaks, so do so.
Mainly to confirm that these are really expensive (on my system, mulitple milliseconds for the descriptor checksum) and that we should precompute these values rather than suggesting users compute them at run-time whenever they want to do correction (which would result in a simpler API).
apoelstra
force-pushed
the
2024-03--restore-benches
branch
from
82a577d
to
e0b95f1
Compare
|
Rebased, added a one-line warning fix from my |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #128 we dropped the benchmarks. They can be restored with only minor tweaks, so do so.