-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release tracking PR: hex-conservative 0.3.0
#110
Draft
tcharding
wants to merge
2
commits into
rust-bitcoin:master
Choose a base branch
from
tcharding:09-18-release-0.3.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcharding
force-pushed
the
09-18-release-0.3.0
branch
from
September 18, 2024 03:29
ce1a9b6
to
77ac8a4
Compare
Includes a patch upfront to fix fuzz job. |
tcharding
changed the title
Release tracking PR:
Release tracking PR: Sep 18, 2024
hex-conservative v0.3.0
hex-conservative 0.3.0
tcharding
force-pushed
the
09-18-release-0.3.0
branch
from
September 18, 2024 04:12
77ac8a4
to
58c1d24
Compare
In the `fuzz` job we are using `upload-artifact@v2` (and download) and CI auto-fails because this version has been deprecated. Upgrade to version 3.
In preparation for release add a changelog entry and bump the version. Major release because it includes at least one breaking change (removal of `core2` optional dependency).
tcharding
force-pushed
the
09-18-release-0.3.0
branch
from
September 18, 2024 04:13
58c1d24
to
b68ac5b
Compare
Can you split the CI fix out? This crate doesn't have lockfiles which makes it hard for me to test version-changing PRs where different commits have different verions. |
No sweat, I can add lock files too if it helps? |
Patch 1 is now in #111 |
This would be super helpful for me, yeah. |
Draft till #112 goes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for release add a changelog entry and bump the version.
Major release because it includes at least one breaking change (removal of
core2
optional dependency).