Switch to chacha20-poly1305 crate #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyonson
force-pushed
the
deprecate-chacha
branch
from
06e8e9e
to
53402a1
Compare
nyonson
force-pushed
the
deprecate-chacha
branch
2 times, most recently
from
b1e865f
to
e3ae6bc
Compare
| @@ -96,7 +94,7 @@ impl FSChaCha20Poly1305 { | |||
| /// | |||
| /// The 16-byte authentication tag. | |||
| pub fn encrypt(&mut self, aad: &[u8], content: &mut [u8]) -> [u8; 16] { | |||
| let cipher = ChaCha20Poly1305::new(self.key, self.nonce()); | |||
| let cipher = ChaCha20Poly1305::new(self.key, Nonce::new(self.nonce())); | |||
There was a problem hiding this comment.
Maybe in future versions of chacha we can have the nonce implement std::ops::Add
|
Can we squash these to one commit? I think they are pretty related. Huge to see all this hard work paying off! |
nyonson
force-pushed
the
deprecate-chacha
branch
from
e3ae6bc
to
4fabce3
Compare
|
ACK 4fabce3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop the internal implementation for the new and improved version in rust-bitcoin which includes the SIMD optimizations.
Also promoted the Key type for a little more type safety.