Merge pull request #65 from rust-bio/dependabot/cargo/serde-1.0.174 #26
dlaehnemann
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
5 warnings
|
dereferencing a tuple pattern where every element takes a reference:
src/strand.rs#L296
warning: dereferencing a tuple pattern where every element takes a reference
--> src/strand.rs:296:36
|
296 | (&Option::Some(ref x), &Option::Some(ref x1)) => x.same(x1),
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
help: try removing the `&` and `ref` parts
|
296 - (&Option::Some(ref x), &Option::Some(ref x1)) => x.same(x1),
296 + (&Option::Some(ref x), Option::Some(x1)) => x.same(x1),
|
|
|
dereferencing a tuple pattern where every element takes a reference:
src/strand.rs#L296
warning: dereferencing a tuple pattern where every element takes a reference
--> src/strand.rs:296:14
|
296 | (&Option::Some(ref x), &Option::Some(ref x1)) => x.same(x1),
| ^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference
= note: `#[warn(clippy::needless_borrowed_reference)]` on by default
help: try removing the `&` and `ref` parts
|
296 - (&Option::Some(ref x), &Option::Some(ref x1)) => x.same(x1),
296 + (Option::Some(x), &Option::Some(ref x1)) => x.same(x1),
|
|
|
this `impl` can be derived:
src/sequence.rs#L61
warning: this `impl` can be derived
--> src/sequence.rs:61:1
|
61 | / impl Default for SequenceReadPairOrientation {
62 | | fn default() -> Self {
63 | | None
64 | | }
65 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= help: remove the manual implementation...
help: ...and instead derive it...
|
49 + #[derive(Default)]
50 | pub enum SequenceReadPairOrientation {
|
help: ...and mark the default variant
|
58 ~ #[default]
59 ~ None,
|
|
|
this pattern creates a reference to a reference:
src/annot/refids.rs#L70
warning: this pattern creates a reference to a reference
--> src/annot/refids.rs:70:25
|
70 | if let Some(ref r) = self.refids.get(id) {
| ^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
help: try this
|
70 ~ if let Some(r) = self.refids.get(id) {
71 ~ r.clone()
|
|
|
this `impl` can be derived:
src/alignment.rs#L52
warning: this `impl` can be derived
--> src/alignment.rs:52:1
|
52 | / impl Default for AlignmentMode {
53 | | fn default() -> Self {
54 | | AlignmentMode::Global
55 | | }
56 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` on by default
= help: remove the manual implementation...
help: ...and instead derive it...
|
45 + #[derive(Default)]
46 | pub enum AlignmentMode {
|
help: ...and mark the default variant
|
48 ~ #[default]
49 ~ Global,
|
|