fix: Fix to remove the virtual machine storage in deps/finch-core/dow… #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nloads/os by make clean Issue #, if available: #537 *Description of changes:* In finch, when booting a virtual machine using Lima, it is necessary to download the virtual machine storage in QCOW2 format. The QCOW2 virtual machine storage thus downloaded and located in deps/finch-core/downloads/os is not deleted when make clean is run in the home directory as currently implemented. This file may be larger than 500 MB in size and is reported in issue/#537 such that it is expected to be deleted when make clean is run. Therefore, this fix will remove the QCOW2 format downloaded files in deps/finch-core/downloads/os when make clean is run in the home directory. *Testing done:* yes - [x] I've reviewed the guidance in CONTRIBUTING.md By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Signed-off-by: Hayato Kiwata <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nloads/os by make clean
Issue #, if available: #537
Description of changes:
In finch, when booting a virtual machine using Lima, it is necessary to download the virtual machine storage in QCOW2 format.
The QCOW2 virtual machine storage thus downloaded and located in deps/finch-core/downloads/os is not deleted when make clean is run in the home directory as currently implemented.
This file may be larger than 500 MB in size and is reported in issue/#537 such that it is expected to be deleted when make clean is run.
Therefore, this fix will remove the QCOW2 format downloaded files in deps/finch-core/downloads/os when make clean is run in the home directory.
Testing done: yes
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.