-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: auto-generate docs #651
Conversation
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Good to have a gen-docs-no-diff in ci. finch/.github/workflows/ci.yaml Line 37 in e21ae83
|
Signed-off-by: Justin Alvarez <[email protected]>
The nature of this code makes it very hard to add more tests than what I've added in the latest commit. It both modifies os.Stdout, AND is recursive. I tried mocking out the scenario where there's a parent command and it does not seem worth the effort since this is not really a critical command anyway. |
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
Signed-off-by: Justin Alvarez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some small comments. Thanks for the good work!
Signed-off-by: Justin Alvarez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Skipping CI e2e tests take a long time and it's passed previously (these changes are unrelated to e2e tests) |
Issue #, if available:
Description of changes:
finch gen-docs generate
command, which can be used to generate documentationfinch volume create
is a command, with it's own usage information, it won't have a page here. The doc forfinch volume
does reference its subcommands, however.Testing done:
TODO
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.