feat: supports adding files inside the VM to support bundles #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginglis13
reviewed
Aug 30, 2023
sam-berning
force-pushed
the
support-bundles-vm-files
branch
2 times, most recently
from
fd49e67
to
b6b3153
Compare
ginglis13
previously approved these changes
Aug 31, 2023
Yeah, I'll make a follow up PR |
mharwani
reviewed
Sep 7, 2023
sam-berning
force-pushed
the
support-bundles-vm-files
branch
from
b6b3153
to
e31f356
Compare
Signed-off-by: Sam Berning <[email protected]>
sam-berning
force-pushed
the
support-bundles-vm-files
branch
from
e31f356
to
11fcafa
Compare
mharwani
approved these changes
Sep 8, 2023
ginglis13
approved these changes
Sep 8, 2023
KevinLiAWS
pushed a commit
that referenced
this pull request
Sep 26, 2023
🤖 I have created a release *beep* *boop* --- ## [0.9.0](v0.8.0...v0.9.0) (2023-09-25) ### Features * support push with SOCI ([#578](#578)) ([69721b7](69721b7)) * supports adding files inside the VM to support bundles ([#549](#549)) ([3b1df46](3b1df46)) ### Bug Fixes * enables bridge-nf-call-iptables by default ([#539](#539)) ([6ea1499](6ea1499)) * **Makefile:** use POSIX tar syntax for stdin ([#529](#529)) ([e222131](e222131)) ### Build System or External Dependencies * **deps:** Bump github.com/docker/cli from 24.0.5+incompatible to 24.0.6+incompatible ([#560](#560)) ([21bb893](21bb893)) * **deps:** Bump github.com/docker/docker from 24.0.5+incompatible to 24.0.6+incompatible ([#561](#561)) ([e0160be](e0160be)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 ([#542](#542)) ([8536481](8536481)) * **deps:** Bump github.com/runfinch/common-tests from 0.7.2 to 0.7.3 ([#548](#548)) ([a054ef3](a054ef3)) * **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.7 to 3.23.8 ([#552](#552)) ([cf9399a](cf9399a)) * **deps:** Bump golang.org/x/crypto from 0.12.0 to 0.13.0 ([#558](#558)) ([f24264d](f24264d)) * **deps:** Bump golang.org/x/tools from 0.12.0 to 0.13.0 ([#559](#559)) ([0f56d23](0f56d23)) * **deps:** Bump k8s.io/apimachinery from 0.28.0 to 0.28.1 ([#543](#543)) ([675f76f](675f76f)) * **deps:** Bump k8s.io/apimachinery from 0.28.1 to 0.28.2 ([#568](#568)) ([915d658](915d658)) * **deps:** Bump submodules and dependencies ([#544](#544)) ([94b7497](94b7497)) * **deps:** Bump submodules and dependencies ([#551](#551)) ([baf645f](baf645f)) * **deps:** Bump submodules and dependencies ([#565](#565)) ([c02413f](c02413f)) * **deps:** Bump submodules and dependencies ([#567](#567)) ([f70314e](f70314e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ginglis13
pushed a commit
to ginglis13/finch
that referenced
this pull request
Sep 27, 2023
…h#549) Issue #, if available: *Description of changes:* Allows users to add files from inside their finch VM to a support bundle. The file can be specified in a config or in a command line flag with `vm:/path/to/file/in/vm` *Testing done:* ``` make test-unit ``` manual testing - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Sam Berning <[email protected]>
ginglis13
pushed a commit
to ginglis13/finch
that referenced
this pull request
Sep 27, 2023
🤖 I have created a release *beep* *boop* --- ## [0.9.0](runfinch/finch@v0.8.0...v0.9.0) (2023-09-25) ### Features * support push with SOCI ([runfinch#578](runfinch#578)) ([69721b7](runfinch@69721b7)) * supports adding files inside the VM to support bundles ([runfinch#549](runfinch#549)) ([3b1df46](runfinch@3b1df46)) ### Bug Fixes * enables bridge-nf-call-iptables by default ([runfinch#539](runfinch#539)) ([6ea1499](runfinch@6ea1499)) * **Makefile:** use POSIX tar syntax for stdin ([runfinch#529](runfinch#529)) ([e222131](runfinch@e222131)) ### Build System or External Dependencies * **deps:** Bump github.com/docker/cli from 24.0.5+incompatible to 24.0.6+incompatible ([runfinch#560](runfinch#560)) ([21bb893](runfinch@21bb893)) * **deps:** Bump github.com/docker/docker from 24.0.5+incompatible to 24.0.6+incompatible ([runfinch#561](runfinch#561)) ([e0160be](runfinch@e0160be)) * **deps:** Bump github.com/onsi/ginkgo/v2 from 2.11.0 to 2.12.0 ([runfinch#542](runfinch#542)) ([8536481](runfinch@8536481)) * **deps:** Bump github.com/runfinch/common-tests from 0.7.2 to 0.7.3 ([runfinch#548](runfinch#548)) ([a054ef3](runfinch@a054ef3)) * **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.7 to 3.23.8 ([runfinch#552](runfinch#552)) ([cf9399a](runfinch@cf9399a)) * **deps:** Bump golang.org/x/crypto from 0.12.0 to 0.13.0 ([runfinch#558](runfinch#558)) ([f24264d](runfinch@f24264d)) * **deps:** Bump golang.org/x/tools from 0.12.0 to 0.13.0 ([runfinch#559](runfinch#559)) ([0f56d23](runfinch@0f56d23)) * **deps:** Bump k8s.io/apimachinery from 0.28.0 to 0.28.1 ([runfinch#543](runfinch#543)) ([675f76f](runfinch@675f76f)) * **deps:** Bump k8s.io/apimachinery from 0.28.1 to 0.28.2 ([runfinch#568](runfinch#568)) ([915d658](runfinch@915d658)) * **deps:** Bump submodules and dependencies ([runfinch#544](runfinch#544)) ([94b7497](runfinch@94b7497)) * **deps:** Bump submodules and dependencies ([runfinch#551](runfinch#551)) ([baf645f](runfinch@baf645f)) * **deps:** Bump submodules and dependencies ([runfinch#565](runfinch#565)) ([c02413f](runfinch@c02413f)) * **deps:** Bump submodules and dependencies ([runfinch#567](runfinch#567)) ([f70314e](runfinch@f70314e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Allows users to add files from inside their finch VM to a support bundle. The file can be specified in a config or in a command line flag with
vm:/path/to/file/in/vmTesting done:
manual testing
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.